[Twig] allow ExposeInTemplate to be used on public component methods
#326
+67
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kbond
commented
May 27, 2022
kbond
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| Tickets | n/a |
| License | MIT |
weaverryan
approved these changes
May 31, 2022
| $attribute = $attribute->newInstance(); | ||
|
|
||
| /** @var ExposeInTemplate $attribute */ | ||
| $name = $attribute->name ?? (str_starts_with($method->name, 'get') ? lcfirst(substr($method->name, 3)) : $method->name); |
There was a problem hiding this comment.
It'd be great if we could reuse the logic from Twig or PropertyAccessor or ApiPlatform to determine the right "name" to use... but I'm not aware of any way to do that.
|
Thanks Kevin! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.