Unset TomSelect after destroying the Stimulus Controller #409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janklan
changed the title
This was referenced Aug 7, 2022
weaverryan
reviewed
Aug 9, 2022
| @@ -41,6 +41,8 @@ export default class extends Controller { | |||
|
|
|||
| disconnect() { | |||
| this.tomSelect.destroy(); | |||
| // Fixes https://github.com/symfony/ux/issues/407 | |||
| this.tomSelect = undefined; | |||
There was a problem hiding this comment.
Yup, good catch - that was an oversight.
|
Thanks @janklan! |
|
@weaverryan this failed the build since |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes Stimulus re-uses an instance of a controller after it's destroyed and re-created - for example when a Live Twig Component re-renders. Without unsetting the variable, connect() method thinks TomSelect is already in place, and does nothing.