[Live] Lower the normalizer priority of DoctrineObjectNormalizer and fix embeddables
#453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbond
force-pushed
the
normalize-objects
branch
2 times, most recently
from
d14d4fd to
6ad9aec
Compare
Changed from 100 to -100, we want a user's entity normalizers to run before. We also want `DoctrineObjectNormalizer` to run before the default object normalizer.
kbond
force-pushed
the
normalize-objects
branch
from
6ad9aec to
d295fa8
Compare
kbond
commented
Sep 9, 2022
| /** | ||
| * Ensure the $class is not embedded or a mapped superclass. | ||
| */ | ||
| private static function ensureManagedObject(ObjectManager $om, string $class): ?ObjectManager |
There was a problem hiding this comment.
See #452 (comment) for why this is needed.
kbond
changed the title
DoctrineObjectNormalizerDoctrineObjectNormalizer and fix embeddables
|
Thanks Kevin! |
|
Yes - thanks for your efforts Kevin. @weaverryan Do you know when you are likely to tag a release with these changes? Thanks. |
|
Not sure - maybe a week or two - I have some other changes I'd like to get in first - but typically we're releasing monthly, and it's nearly been a month. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed from 100 to -100, we want a user's entity normalizers to run before. We also want
DoctrineObjectNormalizerto run before the default object normalizer.Tests added to cover the following ways object properties on a component are normalized:
DoctrineObjectNormalizer)