[Autocomplete] Correct Method Name for FQCN #458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the current method does not seem to exist, but this one will return the FQCN of the metadata being wrapped, which seems to be what it intends to do. there are no tests for this code atm, and the ClassMetadata service has properties accessed which do not exist on the interface which makes mocking or adding a dummy problematic. static analysis would also have trouble here I think.
rodnaph
changed the title
|
You're absolutely right - probably some copy and pasting mistake by me. Thanks @rodnaph! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current method does not seem to exist, but this one will return the FQCN of the metadata being wrapped, which seems to be what it intends to do.
This bug triggers when a specified search property does not exist, and an exception is thrown when creating the exception message.
There are no tests for this code atm, and the
ClassMetadataservice has properties accessed which do not exist on the interface which makes mocking or adding a dummy problematic. Static analysis would also have trouble here I think.I'm happy to spend time adding these tests, but unsure if this is the right fix right now, perhaps I missed something.