[Notify] Add Notify bundle

[mtarld]

Q	A
Bug fix?	no
New feature?	yes
Tickets
License	MIT

In Symfony 5.3, Notifier was shipped with a Mercure bridge (symfony/symfony#39342)

Then, with a simple $this->notifier->send(new Notification('My message', ['chat/mercure'])); (and a running Mercure server), it'll be easy to create "Server-Sent-Events".

Therefore, the Notify bundle idea is to listen to these events using JavaScript event sourcing and convert them as native HTML5 notifications (using the {{ stream_notifications() }} Twig function).

(The "Notify" name was the first that came to my mind a could/should be challenged)

[seb-jean]

Hi 😃 ,

With this bundle, will it be web push notifications (with allow and block) or simple notifications?

Push notifications :

Simple notification :

Thanks :)

[tgalopin]

Push notifications (native)

[tgalopin]

Hello @mtarld

I think this component still makes sense, could we perhaps use latest Symfony changes (especially on ux-mercure) to finalize it? Would you have time to have a look at the failing tests/rebasing?

[mtarld]

Hi @tgalopin!
Yes indeed, I think it is worth it! A lot of improvements and changes happened, I'll update the bundle consequently 🙂

[mtarld]

Hi @tgalopin! I updated the bundle to be consistent with other bundles (and to reuse some good ideas taken from ux-turbo-mercure)

Still, some questions remain:

• As the notify bundle is tightly coupled to mercure, should we name the bundle after it? Something like MercureNotify with a stream_mercure_notification twig function?
• Actually, symfony/mercure-notifier is a strong composer dependency of the bundle. But it could actually work without (as the bundle is just a "listener"). Maybe we can instead change that dependency to a composer suggestion?

[yceruto]

LGTM

[weaverryan]

Very cool 😎

[mtarld]

As we required PHP 8.1 for that bundle, I updated the test workflow to run the bundle's tests on PHP 8.1.
I think we may test other bundles over PHP 8.1 instead of 8.0 in another PR.
WDYT?

[mtarld]

Thanks for that wonderful review @weaverryan 🙂!

[weaverryan]

As we required PHP 8.1 for that bundle, I updated the test workflow to run the bundle's tests on PHP 8.1.
I think we may test other bundles over PHP 8.1 instead of 8.0 in another PR.
WDYT?

The test matrix DOES need some work. But if a bundle advertises that it works on php8, we need to keep testing it on php 8.0 (though, we should probably also test on php 8.1). Btw, I think we need to improve the test matrix further to be dynamic. There is way too much repeated config, and that's only going to get worse as the number of components grows. If you're interested, I had a WIP version of this at https://github.com/weaverryan/ux/tree/typescript-central-ci - where each package created a dynamic build. I think it's an interesting approach.

For this PR, I'd love to see your excellent explanation put into the docs. But after that, it's ready to merge!

[weaverryan]

Suggested change

	Then, you can inject the ``NotifierInterface`` service and send messages on the ``chat/mercure`` channel::
	Then, you can inject the ``NotifierInterface`` service and send messages on the ``chat/myMercureChatter `` channel::

[weaverryan]

This looks a tiny bit to short

[weaverryan]

Thank you Mathias! Wonderful work!

[weaverryan]

Docs tweak over at #325