[Autocomplete] implement preload option
#539
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seb-jean
changed the title
preload option
weaverryan
reviewed
Nov 9, 2022
| get preload() { | ||
| if (this.preloadValue == 'false') return false; | ||
| if (this.preloadValue == 'true') return true; | ||
| return this.preloadValue; |
There was a problem hiding this comment.
Can you add some { to the if statements to standardize with the coding style? And also an empty break before the return statement. thx :)
There was a problem hiding this comment.
I changed the if statements.
I don't see where you want me to put the break.
There was a problem hiding this comment.
Sorry, I meant an empty line break. You did it perfectly 👍
| } | ||
|
|
||
| return $value; | ||
| }); |
There was a problem hiding this comment.
Would it work if we removed this and, instead, above, did:
$values['preload'] = json_encode($options['preload']);There was a problem hiding this comment.
For boolean values it works, but not for strings
|
Thanks for this nice PR @seb-jean! |
weaverryan
added a commit
that referenced
this pull request
Nov 29, 2022
…t (weaverryan) This PR was merged into the 2.x branch. Discussion ---------- [Autocomplete] Setting preload back to "focus" as the default | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | Tickets | None | License | MIT Hi! In 2.6.0, #539 accidentally changed the `preload` behavior from `focus` to `false`. The result is that, in 2.5.0, clicking on an autocomplete field will instantly make an Ajax call to load options. But in 2.6.0, clicking on it does nothing, until you type a few characters. This changes back to the old default, which I like better, and also (maybe more importantly) is the previous behavior. Cheers! Commits ------- 04cc08f Setting preload back to "focus" as the default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added preload option to control the preload.
Default value is
false