Skip to content

Add all possible CSS files to the autoimport #554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 28, 2022
Merged

Conversation

mneuhaus
Copy link
Contributor

Came up during a workshop, that it might make sense to include all possible stylesheets in the autoimport. Default is true, all others false but can then be easily switched

Q A
Bug fix? no
New feature? yes
License MIT

@mneuhaus
Copy link
Contributor Author

i think, the 1 failing check is unrelated to this change

"tom-select/dist/css/tom-select.default.css": true
"tom-select/dist/css/tom-select.default.css": true,
"tom-select/dist/css/tom-select.bootstrap4.css": false,
"tom-select/dist/css/tom-select.bootstrap5.css": false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In another PR, I'm going to be pragmatic, though inconsistent, and remove bootstrap4 :)

@weaverryan
Copy link
Member

Thanks for this! I love when PR's come out of workshop real-world experiences :)

@weaverryan weaverryan merged commit aae7bc0 into symfony:2.x Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants