[Live] Show a clear error multiple roots + resolve Component promise after render #588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
force-pushed
the
live-clear-error-multiple-roots
branch
from
cad3af2 to
5d0c947
Compare
weaverryan
force-pushed
the
live-clear-error-multiple-roots
branch
from
5d0c947 to
6faa252
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
A) Ignore "comment" or "text" nodes if they are at the "root" level
B) Throw a clear error if the component has multiple elements (no re-render)
C) Resolve the Component promise after re-rendering. This is how this was intended, it allows you to, for example,
await component.render()and your code will continue only after the Ajax call and re-render have finished.