[Live] Adding 2 errors related to an invalid component set up #590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
commented
Dec 2, 2022
| } | ||
|
|
||
| throw new \LogicException($message, 0, $exception); | ||
| } |
There was a problem hiding this comment.
An example of this:
I wish I could add line breaks, but at least all the info is there.
1) A better error if you have an uninitiailzed property, though there are still other cases of uninitialized properties that aren't handled yet. 2) A better error if there is a problem hydrating an object through the serializer.
weaverryan
force-pushed
the
serializer-exception-messages
branch
from
9d75871 to
38833d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A better error if you have an uninitiailzed property, though there are still other cases of uninitialized properties that aren't handled yet.
A better error if there is a problem hydrating an object through the serializer.
Btw, I'm still not convinced we should use the serializer automatically to (de)hydrate properties. But anyways, even if we decide to NOT do this by default, it would still be something the user could easily enable... and so having a nice message is important.