Outputting Typescript types #609
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
force-pushed
the
typescript_types
branch
from
2bd1eff to
bbda93a
Compare
We no longer parse ALL .ts files for EACH package we're building with rollup. Also, we ouput the the type files straight from rollup back
weaverryan
force-pushed
the
typescript_types
branch
from
bbda93a to
715c289
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This outputs proper TypeScript type files. As a bonus, I found the bug in our build system that was making
yarn buildWAY too slow. The GH action that checks for out-of-date build files is now reactivated ⭐I decided to output all
.d.tsfiles, even for modules that are considered "internal". I thought about only exporting types from the "main" file... but libraries like Stimulus seem to export everything. Mostly, I'd like to follow whatever is "most normal".Cheers!