[Live] Dispatch browser events #794
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
force-pushed
the
live-dispatch-browser-events
branch
from
bfccdfa to
e2ca326
Compare
norkunas
reviewed
Apr 17, 2023
|
|
||
| .. code-block:: html+twig | ||
|
|
||
| <div class="modal fade" {{ stimulus_controller('bootstrap-modal') }}"> |
There was a problem hiding this comment.
Redundant quote at the end?
There was a problem hiding this comment.
Absolutely - thanks for mentioning that :) - fixed in an upcoming PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I figured we'd need this eventually :). While building an component that opens/closes a modal, I needed a way to close the modal from a
LiveActionin PHP. The way to do that is to dispatch a DOM event from the action, then listen to that with a tiny bit of JavaScript that closes the modal. Modeled after Livewire, like with emit(). Super simple.Also fixed a bug with
attributes.add()on non-live components.Cheers!