Skip to content

[Live] Fix checksum calculation for deeply nested data #798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2023
Merged

[Live] Fix checksum calculation for deeply nested data #798

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/LiveComponent/src/LiveComponentHydrator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ private static function coerceStringValue(string $value, string $type, bool $all
private function calculateChecksum(array $dehydratedPropsData): ?string
{
// sort so it is always consistent (frontend could have re-ordered data)
ksort($dehydratedPropsData);
$this->recursiveKeySort($dehydratedPropsData);

return base64_encode(hash_hmac('sha256', json_encode($dehydratedPropsData), $this->secret, true));
}
Expand Down Expand Up @@ -550,4 +550,14 @@ private function combineAndValidateProps(array $props, array $updatedPropsFromPa

return $dehydratedOriginalProps;
}

private function recursiveKeySort(array &$data): void
{
foreach ($data as &$value) {
if (\is_array($value)) {
$this->recursiveKeySort($value);
}
}
ksort($data);
}
}