Fixing reset assets trigger on sub-requests #172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
force-pushed
the
fix-finish-request-multiple-trigger
branch
from
fa56bc7 to
2dd0ffc
Compare
|
Thank you Tarik! This is a complex issue. Let's see if this can fix the bad behavior without introducing any other problems. |
This was referenced May 3, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.14.0is broken when a page contains sub requests, all the files managed by the package run twice. The eventKernelEvents::FINISH_REQUESTshould be handled for MainRequest only.Sadly we are stuck at 1.13.2 until it's fixed