Builds cache keys are improperly composed #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViniTou
approved these changes
Mar 4, 2019
pawbuj
approved these changes
Mar 4, 2019
Nattfarinn
approved these changes
Mar 4, 2019
|
Looks like it duplicates #50. |
webhdx
changed the title
weaverryan
added a commit
that referenced
this pull request
Mar 4, 2019
This PR was squashed before being merged into the master branch (closes #51). Discussion ---------- Builds cache keys are improperly composed Looks like ba327cd has an issue with `builds` configuration. I have my app configures to use multiple builds: ```yaml webpack_encore: output_path: "%kernel.project_dir%/web/assets/build" builds: custom_build: "%kernel.project_dir%/web/assets/custom_build/build" ``` which was failing on `cache:clear`: ``` In EntrypointLookup.php line 111: [InvalidArgumentException] There was a problem JSON decoding the "/Users/maciejkobus/Projects/ezplatform/web/assets/custom_build/build" file ``` To my understanding it is trying to parse directory as a JSON and indeed it looks like cache keys are improperly combined in the Extension class. Commits ------- 7f6e111 Merge branch 'master' into multiple_builds_cache_keys b22f685 Fixed issue with invalid cache keys for builds
|
@weaverryan could you make a new release tag on this package? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like ba327cd has an issue with
buildsconfiguration. I have my app configures to use multiple builds:which was failing on
cache:clear:To my understanding it is trying to parse directory as a JSON and indeed it looks like cache keys are improperly combined in the Extension class.