Added strict mode #43 #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @weaverryan , Do you think it can be merged? Please take a look at this PR |
weaverryan
requested changes
Mar 25, 2019
weaverryan
requested changes
Apr 10, 2019
|
@weaverryan fixed and rebased. |
|
@weaverryan Have you had time to look into this? I think it's ready for merge |
|
Very well done! Thanks for the great work and your patience @karser! |
weaverryan
added a commit
that referenced
this pull request
May 26, 2019
This PR was merged into the master branch. Discussion ---------- Added strict mode #43 This PR introduces `strict_mode` which is true by default so it doesn't change the original bundle behavior. If set to false it suppresses all the exceptions thrown because of missing builds. It makes sense to disable strict mode for test environment where you don't need to build your assets. ``` # config/packages/test/webpack_encore.yaml webpack_encore: strict_mode: false ``` Here is the original issue #43 Commits ------- a74a5a2 Added strict mode
|
I'm glad it's merged! 👍 |
javiereguiluz
added a commit
to javiereguiluz/symfony-docs
that referenced
this pull request
Sep 22, 2022
…losoft) This PR was submitted for the 6.0 branch but it was squashed and merged into the 5.4 branch instead. Discussion ---------- Add information about strict_mode for encore I guess it should be both in `5.4` and `6.0`, but actually will be useful down to whenever symfony/webpack-encore-bundle#54 was merged Personally, it took me quite a long time to determine and fix the cause of functional tests failing in CI. I know that stuff is kind of mentioned in `config/packages/webpack_encore.yaml`, but here are my excuses * there is certain time gap between you first install webpack, write your functional tests (involved with actual HTML rendering), add some styles/scripts to template and setup CI to run these tests * this stuff is not mentioned in the docs at all - `fgrep -RH strict_mode .` gives 0 results Commits ------- 2b6371f Add information about strict_mode for encore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces
strict_modewhich is true by default so it doesn't change the original bundle behavior. If set to false it suppresses all the exceptions thrown because of missing builds. It makes sense to disable strict mode for test environment where you don't need to build your assets.Here is the original issue #43