Skip to content

Run php-cs-fixer over the bundle using preexisting .php_cs.dist rules #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

PhilETaylor
Copy link
Contributor

Manually enforce php_cs rules over /src and /tests

~/build/vendor/symfony/webpack-encore-bundle(patch-1 ✗) php-cs-fixer fix --config=.php_cs.dist -vvv .
Loaded config default from ".php_cs.dist".
Using cache file ".php_cs.cache".
Paths from configuration file have been overridden by paths provided as command arguments.
FFFFS.FSSFSSS..SS
Legend: ?-unknown, I-invalid file syntax, file ignored, S-Skipped, .-no changes, F-fixed, E-error
   1) tests/Asset/EntrypointLookupTest.php (single_quote, php_unit_fqcn_annotation, no_unused_imports, header_comment)
   2) tests/Asset/EntrypointLookupCollectionTest.php (function_declaration, php_unit_fqcn_annotation, header_comment)
   3) tests/Asset/TagRendererTest.php (concat_space, function_declaration, header_comment)
   4) tests/IntegrationTest.php (concat_space, trailing_comma_in_multiline_array, function_declaration, header_comment, binary_operator_spaces)
   5) src/Asset/EntrypointLookupCollectionInterface.php (phpdoc_annotation_without_dot)
   6) src/Asset/EntrypointLookup.php (native_function_invocation)

Fixed all files in 0.318 seconds, 12.000 MB memory used

@PhilETaylor PhilETaylor closed this Apr 5, 2019
@PhilETaylor PhilETaylor deleted the php_cs branch April 5, 2019 13:43
@weaverryan
Copy link
Member

Why did you close @PhilETaylor?

@PhilETaylor
Copy link
Contributor Author

I was not aware I did! Apparently I deleted the branch in my fork and that auto closed this :-( Sorry about that.

Im out all day today, but will reinstate this PR this evening.

@PhilETaylor
Copy link
Contributor Author

I ran php-cs-fixer again just now and created #60 for some reason its only modifying less files this time as Im running it against master and not my patch-1 branch :) so all good :)

@PhilETaylor
Copy link
Contributor Author

for some reason its only modifying less files this time

because I forgot to add the tests folder into the config - done now - #60 replaces this one, sorry about that, I did not remember this PR when cleaning up my branches

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants