Allow entrypoints.json to be hosted remotely #97
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlvdx
force-pushed
the
allow-entrypoints-file-to-be-hosted-remotely
branch
from
8acb968 to
52670b6
Compare
|
hi, any news? it's any plan to implement this feature? |
Doesn't look like it, and I don't know how to make things go forward :) |
|
Hello, I am in the same situation as you ... your solution seems viable to me too! |
Ahummeling
approved these changes
Jul 27, 2022
|
I'm on it :) |
|
Sorry but I wasn't able to push on your PR, instead I've opened a new PR #236 |
Kocal
added a commit
that referenced
this pull request
Oct 1, 2024
…uvradoux, Kocal) This PR was merged into the 2.x branch. Discussion ---------- Allow entrypoints.json to be hosted remotely Fixes #76 See #97, this PR uses the Symfony HttpClient to remotely fetch the entrypoints file, but also to allow mocking in a proper way. It also add/adapt many tests, and improve the documentation. Commits ------- f5b9a1d Use HttpClient instead of file_get_contents(), add tests and documentation 2fe9a88 Allow entrypoints.json to be hosted remotely
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #76
file_existsonentrypoints.jsonfails.strict_modeistrue, an exception is raised and it's imposible to load the assets.file_get_contentsis used to retrieve theentrypoints.jsoncontents.What I'm proposing is to use
file_get_contentsearlier to allow fetching a remoteentrypoints.jsonto solve the CDN use case. Does it seem OK?On a side note, I don't see how to run the tests locally, so the feedback loop with TRavis makes it difficult to fix them. How should I do? Thanks :)