Skip to content

Commit d11f998

Browse files
committed
bug #46 Removing window.jQuery from autoProvidejQuery (weaverryan)
This PR was merged into the master branch. Discussion ---------- Removing window.jQuery from autoProvidejQuery Fixes #32 This is because - when this is enabled - it's impossible to expose jQuery as a global variable on window (without use the expose loader). Specifically, window.jQuery = ... is re-written in your JS code. A docs PR also needs to be opened to document how to fix problems if a library depends on `window.jQuery` specifically (is there a good re-world example?) Commits ------- 3703a5a Removing window.jQuery from autoProvidejQuery
2 parents 71eea68 + 3703a5a commit d11f998

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

lib/WebpackConfig.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -244,7 +244,6 @@ class WebpackConfig {
244244
this.autoProvideVariables({
245245
$: 'jquery',
246246
jQuery: 'jquery',
247-
'window.jQuery': 'jquery'
248247
});
249248
}
250249

0 commit comments

Comments
 (0)