Removing window.jQuery from autoProvidejQuery #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is because - when this is enabled - it's impossible to expose jQuery as a global variable on window (without use the expose loader). Specifically, window.jQuery = ... is re-written in your JS code.
Closed
|
I'm going to merge this so that the next release contains the same code (i.e. without |
weaverryan
added a commit
that referenced
this pull request
Jun 21, 2017
This PR was merged into the master branch. Discussion ---------- Removing window.jQuery from autoProvidejQuery Fixes #32 This is because - when this is enabled - it's impossible to expose jQuery as a global variable on window (without use the expose loader). Specifically, window.jQuery = ... is re-written in your JS code. A docs PR also needs to be opened to document how to fix problems if a library depends on `window.jQuery` specifically (is there a good re-world example?) Commits ------- 3703a5a Removing window.jQuery from autoProvidejQuery
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #32
This is because - when this is enabled - it's impossible to expose jQuery as a global
variable on window (without use the expose loader). Specifically, window.jQuery = ...
is re-written in your JS code.
A docs PR also needs to be opened to document how to fix problems if a library depends on
window.jQueryspecifically (is there a good re-world example?)