Skip to content

Add window.jquery to autoProvidejQuery() #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 13, 2017
Merged

Add window.jquery to autoProvidejQuery() #10

merged 2 commits into from
Jun 13, 2017

Conversation

alOneh
Copy link
Contributor

@alOneh alOneh commented Jun 13, 2017

When using webpack it's common to also provide window.jQuery because some libraries use it this way.

@alOneh alOneh mentioned this pull request Jun 13, 2017
Closed
2 tasks
@weaverryan
Copy link
Member

👍

@weaverryan
Copy link
Member

Thank you!

@weaverryan weaverryan merged commit 39fe1d3 into symfony:master Jun 13, 2017
weaverryan added a commit that referenced this pull request Jun 13, 2017
@weaverryan
feature #10 Add window.jquery to autoProvidejQuery() (alOneh, weaverr…
ba34a7f 
…yan)

This PR was merged into the master branch.

Discussion
----------

Add window.jquery to autoProvidejQuery()

When using webpack it's common to also provide window.jQuery because some libraries use it this way.

Commits
-------

39fe1d3 cs
63a2920 Add window.jquery to autoProvidejQuery()
@alOneh
Copy link
Contributor Author

alOneh commented Jun 13, 2017

@weaverryan can you tag a new version ?

@alOneh alOneh mentioned this pull request Jun 19, 2017
Closed
@weaverryan weaverryan mentioned this pull request Jun 23, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alOneh @weaverryan