Skip to content

[dependencies] drop node 10 support #1037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions .github/workflows/high-depends.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest, windows-2019]
node-versions: [ '10', '16']
node-versions: [ '12', '16']

steps:
- name: Checkout
Expand All @@ -30,11 +30,6 @@ jobs:

- name: Install Yarn Dependencies
run: yarn install
if: matrix.node-versions != 10

- name: Install Yarn Dependencies Ignore Engines (Node 10)
run: yarn install --ignore-engines
if: matrix.node-versions == 10

- name: Show Installed Versions
run: yarn list --depth=0
Expand Down
7 changes: 1 addition & 6 deletions .github/workflows/low-depends.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest, windows-2019]
node-versions: [ '10', '16']
node-versions: [ '12', '16']

steps:
- name: Checkout
Expand All @@ -33,11 +33,6 @@ jobs:

- name: Install Yarn Dependencies
run: yarn install
if: matrix.node-versions != 10

- name: Install Yarn Dependencies Ignore Engines (Node 10)
run: yarn install --ignore-engines
if: matrix.node-versions == 10

- name: Show Installed Versions
run: yarn list --depth=0
Expand Down
7 changes: 1 addition & 6 deletions .github/workflows/stable-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest, windows-2019]
node-versions: [ '10', '12', '14', '16']
node-versions: [ '12', '14', '16']

steps:
- name: Checkout
Expand All @@ -27,11 +27,6 @@ jobs:

- name: Install Yarn Dependencies
run: yarn install
if: matrix.node-versions != 10

- name: Install Yarn Dependencies Ignore Engines (Node 10)
run: yarn install --ignore-engines
if: matrix.node-versions == 10

- name: Show Installed Versions
run: yarn list --depth=0
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"url": "https://github.com/symfony/webpack-encore/issues"
},
"engines": {
"node": "^10.19.0 || ^12.0.0 || >=14.0.0"
"node": "^12.0.0 || >=14.0.0"
},
"homepage": "https://github.com/symfony/webpack-encore",
"dependencies": {
Expand Down