Skip to content

Use cli param server-type to define devServer https mode #1118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 31, 2022

Conversation

gillesdalle
Copy link
Contributor

Check also the serverType cli param to define if the devServer is in https mode

@gillesdalle gillesdalle changed the title Update parse-runtime.js Use cli param server-type to define devServer https mode May 13, 2022
@weaverryan
Copy link
Member

This makes sense - thanks Gilles!

@weaverryan weaverryan merged commit bff8c9e into symfony:main May 31, 2022
weaverryan added a commit that referenced this pull request Jul 6, 2022
…pack-dev-server (weaverryan)

This PR was squashed before being merged into the main branch.

Discussion
----------

Changing to support the "server" options object for webpack-dev-server

Follow up to #1118 and solves #1119.

The new `server` object has existed since `webpack-dev-server` 4.4 webpack/webpack-dev-server#3940, and we already require 4.8.

Support for the old `https` kept for now (with deprecations) to help people migrate.

Commits
-------

e0fb0ad Changing to support the "server" options object for webpack-dev-server
@weaverryan weaverryan added the Feature New Feature label Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants