Add vue loader #34
Closed
Add vue loader #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
# Conflicts: # test/WebpackConfig.js
weaverryan
reviewed
Jun 21, 2017
| enableVueLoader(options) { | ||
| this.useVueLoader = true; | ||
| this.vueOptions = options; | ||
| } |
There was a problem hiding this comment.
Can you change options to be a callback, like we do with configureBabel()? The reason is that we will (in order to extract styles) add a bunch of options to the loader automatically. If the user wants to add even more options, we'll want them to do that in callback (we'll pass them our options, then they can change/add them).
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a patch to provide a vue.js support
before :
.addLoader({ test: /\.vue$/, loader: 'vue-loader' })After
.enableVueLoader()