Forcing babel-loader 7.1 and updating resolve-rc for new argument #41
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In babel-loader 7.1, they added a new argument to
resolve-rc
. This updates Encore to require 7.1 and pass in that new argument.Of course, the underlying problem is that we're relying on an internal function - so it's entirely valid for them to break BC. We should obviously minimize doing this, but I still think it's a good idea: I don't want to try to re-implement their logic. For example, there are now 2 new places where you can store the Babel configuration... and by using
resolve-rc
, we're now checking for those automatically.