feat(node): drop support for node 11 (end-of-life since 1 year) #775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lyrkan
approved these changes
May 26, 2020
This comment has been minimized.
This comment has been minimized.
|
Thanks @Kocal |
|
I will rebase #774 |
|
@weaverryan I think it should be great to document this breaking change in https://github.com/symfony/webpack-encore/releases/tag/v0.31.0, WDYT? |
weaverryan
added a commit
that referenced
this pull request
Dec 3, 2020
…ocal) This PR was squashed before being merged into the main branch. Discussion ---------- feat: add support for ESLint 7, drop support ESLint 5 - bump eslint from `^5.15.2 || ^6.0.0` to `^6.0.0 || ^7.0.0`: https://eslint.org/blog/2020/05/eslint-v7.0.0-released - bump eslint-loader from `^3.0.0` to `^4.0.0`, which drop support for Node <10.13.0 and set minimum ESLint support to version 6: https://github.com/webpack-contrib/eslint-loader/blob/master/CHANGELOG.md#400-2020-04-03 - had to fix some linting issues **EDIT:** Ok so ESLint 7 is not compatible with Node 11. This version is in end of life ([End-of-Life releasese](https://github.com/nodejs/Release#end-of-life-releases), should we drop support for Node 11 too? And maybe add support for Node 13 and Node 14? WDYT? **EDIT 2:** PR opened at #775 **EDIT 3:** PR rebased since #775 has been merged Commits ------- 5a1cfb6 feat: add support for ESLint 7, drop support ESLint 5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a proposal for the Node.js 11 support issue I encountered in #774.