Update the JSDoc of configureBabel to warn about .babelrc and node_modules #788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dules Babel supports 2 different types of config files: - .babelrc stops at package boundaries - babel.config.* applies to the whole project, including node_modules Once node_modules is not excluded anymore in the babel-loader configuration, this distinction matters.
|
|
|
Yes, you're absolutely right! I just wanted to add that for the reference. Sorry for the confusion. |
This comment has been minimized.
This comment has been minimized.
|
Thanks @stof We should still implement what I described in #785 (comment), I'll open another issue about it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Babel supports 2 different types of config files:
.babelrcstops at package boundariesbabel.config.*applies to the whole project, includingnode_modulesOnce node_modules is not excluded anymore in the babel-loader configuration, this distinction matters.
Refs #785