Skip to content

Commit 57c08e8

Browse files
authored
Remove NoVoidGetterMethodRule as not that practical (#125)
1 parent a9766b3 commit 57c08e8

15 files changed

+1
-366
lines changed

config/naming-rules.neon

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
rules:
22
- Symplify\PHPStanRules\Rules\Explicit\ExplicitClassPrefixSuffixRule
33
- Symplify\PHPStanRules\Rules\NoReturnSetterMethodRule
4-
- Symplify\PHPStanRules\Rules\NoVoidGetterMethodRule
54
- Symplify\PHPStanRules\Rules\UppercaseConstantRule
65
- Symplify\PHPStanRules\Rules\ClassNameRespectsParentSuffixRule
76
- Symplify\PHPStanRules\Rules\CheckTypehintCallerTypeRule

docs/rules_overview.md

Lines changed: 1 addition & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# 41 Rules Overview
1+
# 40 Rules Overview
22

33
## AnnotateRegexClassConstWithRegexLinkRule
44

@@ -1100,40 +1100,6 @@ final class SkipApiMock extends TestCase
11001100

11011101
<br>
11021102

1103-
## NoVoidGetterMethodRule
1104-
1105-
Getter method must return something, not void
1106-
1107-
- class: [`Symplify\PHPStanRules\Rules\NoVoidGetterMethodRule`](../src/Rules/NoVoidGetterMethodRule.php)
1108-
1109-
```php
1110-
final class SomeClass
1111-
{
1112-
public function getData(): void
1113-
{
1114-
// ...
1115-
}
1116-
}
1117-
```
1118-
1119-
:x:
1120-
1121-
<br>
1122-
1123-
```php
1124-
final class SomeClass
1125-
{
1126-
public function getData(): array
1127-
{
1128-
// ...
1129-
}
1130-
}
1131-
```
1132-
1133-
:+1:
1134-
1135-
<br>
1136-
11371103
## PreferredClassRule
11381104

11391105
Instead of "%s" class/interface use "%s"

src/Rules/NoVoidGetterMethodRule.php

Lines changed: 0 additions & 142 deletions
This file was deleted.

tests/Rules/NoVoidGetterMethodRule/Fixture/SkipAbstractGetter.php

Lines changed: 0 additions & 10 deletions
This file was deleted.

tests/Rules/NoVoidGetterMethodRule/Fixture/SkipGetterWithReturn.php

Lines changed: 0 additions & 13 deletions
This file was deleted.

tests/Rules/NoVoidGetterMethodRule/Fixture/SkipIfElseReturn.php

Lines changed: 0 additions & 17 deletions
This file was deleted.

tests/Rules/NoVoidGetterMethodRule/Fixture/SkipInterfaceContractGetter.php

Lines changed: 0 additions & 10 deletions
This file was deleted.

tests/Rules/NoVoidGetterMethodRule/Fixture/SkipNoThrows.php

Lines changed: 0 additions & 16 deletions
This file was deleted.

tests/Rules/NoVoidGetterMethodRule/Fixture/SkipSetter.php

Lines changed: 0 additions & 12 deletions
This file was deleted.

tests/Rules/NoVoidGetterMethodRule/Fixture/SkipYieldFrom.php

Lines changed: 0 additions & 15 deletions
This file was deleted.

tests/Rules/NoVoidGetterMethodRule/Fixture/SkipYielder.php

Lines changed: 0 additions & 15 deletions
This file was deleted.

tests/Rules/NoVoidGetterMethodRule/Fixture/SomeGetterVoid.php

Lines changed: 0 additions & 12 deletions
This file was deleted.

tests/Rules/NoVoidGetterMethodRule/Fixture/SomeGetterWithNoReturn.php

Lines changed: 0 additions & 12 deletions
This file was deleted.

tests/Rules/NoVoidGetterMethodRule/NoVoidGetterMethodRuleTest.php

Lines changed: 0 additions & 51 deletions
This file was deleted.

tests/Rules/NoVoidGetterMethodRule/config/configured_rule.neon

Lines changed: 0 additions & 5 deletions
This file was deleted.

0 commit comments

Comments
 (0)