Skip to content

Commit a9766b3

Browse files
authored
Remove ForbiddenSameNamedNewInstanceRule as rarely a buggy spot (#123)
1 parent a23355d commit a9766b3

File tree

11 files changed

+1
-326
lines changed

11 files changed

+1
-326
lines changed

docs/rules_overview.md

Lines changed: 1 addition & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# 42 Rules Overview
1+
# 41 Rules Overview
22

33
## AnnotateRegexClassConstWithRegexLinkRule
44

@@ -470,34 +470,6 @@ final class SomeRector implements RectorInterface
470470

471471
<br>
472472

473-
## ForbiddenSameNamedNewInstanceRule
474-
475-
New objects with "%s" name are overridden. This can lead to unwanted bugs, please pick a different name to avoid it.
476-
477-
- class: [`Symplify\PHPStanRules\Rules\Complexity\ForbiddenSameNamedNewInstanceRule`](../src/Rules/Complexity/ForbiddenSameNamedNewInstanceRule.php)
478-
479-
```php
480-
$product = new Product();
481-
$product = new Product();
482-
483-
$this->productRepository->save($product);
484-
```
485-
486-
:x:
487-
488-
<br>
489-
490-
```php
491-
$firstProduct = new Product();
492-
$secondProduct = new Product();
493-
494-
$this->productRepository->save($firstProduct);
495-
```
496-
497-
:+1:
498-
499-
<br>
500-
501473
## NarrowPublicClassMethodParamTypeByCallerTypeRule
502474

503475
Parameters should use "%s" types as the only types passed to this method

src/Rules/Complexity/ForbiddenSameNamedNewInstanceRule.php

Lines changed: 0 additions & 135 deletions
This file was deleted.

tests/Rules/Complexity/ForbiddenSameNamedNewInstanceRule/Fixture/SameObjectAssigns.php

Lines changed: 0 additions & 16 deletions
This file was deleted.

tests/Rules/Complexity/ForbiddenSameNamedNewInstanceRule/Fixture/SkipDifferentNames.php

Lines changed: 0 additions & 16 deletions
This file was deleted.

tests/Rules/Complexity/ForbiddenSameNamedNewInstanceRule/Fixture/SkipForeachNewNesting.php

Lines changed: 0 additions & 17 deletions
This file was deleted.

tests/Rules/Complexity/ForbiddenSameNamedNewInstanceRule/Fixture/SkipForeachVariableAssign.php

Lines changed: 0 additions & 16 deletions
This file was deleted.

tests/Rules/Complexity/ForbiddenSameNamedNewInstanceRule/Fixture/SkipNonObjectAssigns.php

Lines changed: 0 additions & 14 deletions
This file was deleted.

tests/Rules/Complexity/ForbiddenSameNamedNewInstanceRule/Fixture/SkipNullDefaultAssign.php

Lines changed: 0 additions & 20 deletions
This file was deleted.

tests/Rules/Complexity/ForbiddenSameNamedNewInstanceRule/ForbiddenSameNamedNewInstanceRuleTest.php

Lines changed: 0 additions & 48 deletions
This file was deleted.

tests/Rules/Complexity/ForbiddenSameNamedNewInstanceRule/Source/SomeProduct.php

Lines changed: 0 additions & 10 deletions
This file was deleted.

tests/Rules/Complexity/ForbiddenSameNamedNewInstanceRule/config/configured_rule.neon

Lines changed: 0 additions & 5 deletions
This file was deleted.

0 commit comments

Comments
 (0)