Skip to content

Remove NoAbstractMethodRule as way too opinionated #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion config/static-rules.neon
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ rules:

# paths
- Symplify\PHPStanRules\Rules\NoMissingDirPathRule
- Symplify\PHPStanRules\Rules\NoAbstractMethodRule
- Symplify\PHPStanRules\Rules\NoReferenceRule
- Symplify\PHPStanRules\Rules\NoArrayAccessOnObjectRule

Expand Down
34 changes: 1 addition & 33 deletions docs/rules_overview.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# 43 Rules Overview
# 42 Rules Overview

## AnnotateRegexClassConstWithRegexLinkRule

Expand Down Expand Up @@ -550,38 +550,6 @@ final class SomeService

<br>

## NoAbstractMethodRule

Use explicit interface contract or a service over unclear abstract methods

- class: [`Symplify\PHPStanRules\Rules\NoAbstractMethodRule`](../src/Rules/NoAbstractMethodRule.php)

```php
abstract class SomeClass
{
abstract public function run();
}
```

:x:

<br>

```php
abstract class SomeClass implements RunnableInterface
{
}

interface RunnableInterface
{
public function run();
}
```

:+1:

<br>

## NoArrayAccessOnObjectRule

Use explicit methods over array access on object
Expand Down
70 changes: 0 additions & 70 deletions src/Rules/NoAbstractMethodRule.php

This file was deleted.

12 changes: 0 additions & 12 deletions tests/Rules/NoAbstractMethodRule/Fixture/SkipNonAbstractMethod.php

This file was deleted.

10 changes: 0 additions & 10 deletions tests/Rules/NoAbstractMethodRule/Fixture/SomeAbstractMethod.php

This file was deleted.

42 changes: 0 additions & 42 deletions tests/Rules/NoAbstractMethodRule/NoAbstractMethodRuleTest.php

This file was deleted.

5 changes: 0 additions & 5 deletions tests/Rules/NoAbstractMethodRule/config/configured_rule.neon

This file was deleted.

Loading