-
-
Notifications
You must be signed in to change notification settings - Fork 16
Remove use of URL
from node:url
#71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment has been minimized.
This comment has been minimized.
50aaaf0
to
9f0d0e5
Compare
People are using this in browsers. #70 also mentions that this is likely a problem with your bundler that can be solved.
You ran |
@wooorm yep! it pass for me. did it fail for you? The github action pass as well, i have to downgrade typescript to 4.4 and fix one broken test case though, otherwise everything is good. Hmmm, did you make any configuration to ignore |
Ohh it’s been a years old issue with TypeScript, and they solved it 5 days ago: DefinitelyTyped/DefinitelyTyped#58277 (comment) |
URL
from node:url
This comment has been minimized.
This comment has been minimized.
Thanks, released! |
thank you! :) |
Initial checklist
Description of changes
Continuation from #70.
In v7, we can use this package in browser, but because of the
'node:url'
import in v8, browser support is no longer available. The initial dismissal of the issue #70 was due to typescript complain, this PR attempt to address that in hope that it get merged and browser support is re-enabled again.Changelog
\
was added to the filename, but i checked the html there's no such character. Feel free to correct me if i'm wrong.import {URL} from 'node:url'
, from my use case, typescript didn't complain, but if it ever complain, my solution is to introduceDOM
tolibs
intsconfig
.