safe guard in ruby/prefer-endless-method

Author: flyerhzm

lib/ruby/prefer-endless-method.rb

@@ -23,7 +23,12 @@ def one_plus_one = 1 + 1
 
   within_files Synvert::ALL_RUBY_FILES + Synvert::ALL_RAKE_FILES do
     find_node '.def_node[body!=nil][body.body.length=1]' do
-      body_column = mutation_adapter.get_start_loc(node.body.body.first).column
+      first_body_node = node.body.body.first
+      if %i[if_node unless_node].include?(first_body_node.type) && first_body_node.end_keyword.nil?
+        break
+      end
+      break if first_body_node.type == :multi_write_node
+      body_column = mutation_adapter.get_start_loc(first_body_node).column
       new_body = node.body.body.first.to_source.split("\n").map { |line| line.sub(/^ {#{body_column}}/, '') }.join("\n")
       replace_with "def {{name}}{{lparen}}{{parameters}}{{rparen}} = #{new_body}"
     end

spec/ruby/prefer-endless-method_spec.rb

@@ -85,4 +85,34 @@ def generate_invitation_token = loop do
 
     include_examples 'convertable'
   end
+
+  context 'do not process if end_keyword is nil' do
+    let(:test_content) { <<~EOS }
+      def current_user
+        @current_user ||= User.find(session[:user_id]) if session[:user_id]
+      end
+    EOS
+    let(:test_rewritten_content) { <<~EOS }
+      def current_user
+        @current_user ||= User.find(session[:user_id]) if session[:user_id]
+      end
+    EOS
+
+    include_examples 'convertable'
+  end
+
+  context 'do not process for multi_write_node' do
+    let(:test_content) { <<~EOS }
+      def index
+        @pagy, @builds = pagy(@organization.builds)
+      end
+    EOS
+    let(:test_rewritten_content) { <<~EOS }
+      def index
+        @pagy, @builds = pagy(@organization.builds)
+      end
+    EOS
+
+    include_examples 'convertable'
+  end
 end