Skip to content

Commit 51112bf

Browse files
committed
allow instance_variable_or_write_node and class_variable_or_write_node in ruby/prefer-endless-method
1 parent 56dfd08 commit 51112bf

File tree

2 files changed

+1
-24
lines changed

2 files changed

+1
-24
lines changed

lib/ruby/prefer-endless-method.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ def one_plus_one = 1 + 1
2828

2929
first_body_node = node.body.body.first
3030
break if %i[if_node unless_node].include?(first_body_node.type) && first_body_node.end_keyword.nil?
31-
break if %i[multi_write_node instance_variable_or_write_node class_variable_or_write_node or_node and_node hash_node].include?(first_body_node.type)
31+
break if %i[multi_write_node or_node and_node hash_node].include?(first_body_node.type)
3232
break if first_body_node.type == :call_node && first_body_node.opening.nil? && !first_body_node.arguments.nil? && first_body_node.closing.nil? && !first_body_node.block.nil?
3333

3434
body_column = mutation_adapter.get_start_loc(first_body_node).column

spec/ruby/prefer-endless-method_spec.rb

Lines changed: 0 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -116,29 +116,6 @@ def index
116116
include_examples 'convertable'
117117
end
118118

119-
context 'do not process for class_variable_or_write_node, instance_variable_or_write_node' do
120-
let(:test_content) { <<~EOS }
121-
def class_logger
122-
@@logger ||= nil
123-
end
124-
125-
def instance_logger
126-
@logger ||= nil
127-
end
128-
EOS
129-
let(:test_rewritten_content) { <<~EOS }
130-
def class_logger
131-
@@logger ||= nil
132-
end
133-
134-
def instance_logger
135-
@logger ||= nil
136-
end
137-
EOS
138-
139-
include_examples 'convertable'
140-
end
141-
142119
context 'do not process for or_node' do
143120
let(:test_content) { <<~EOS }
144121
def new_rating=(new_rating)

0 commit comments

Comments
 (0)