Update README to clarify make arch-test usage #583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running make arch-test without explicitly setting ENABLE_ARCH_TEST=1 may fail due to missing prebuilt binaries. This issue arises because the default value of ENABLE_ARCH_TEST is 0, stopping Sail model from being fetched. Additionally, if ENABLE_SYSTEM=1 was previously set, the build system fetches the kernel image instead of the Sail model. To ensure the correct prebuilt binary is fetched, it is recommended to run make distclean beforehand. This serves as a temporary solution to sysprog21#575.
Code Review Agent Run Status
|
jserv
requested review from
ChinYikMing and
vacantron
and removed request for
ChinYikMing
vacantron
approved these changes
Mar 4, 2025
|
Thank @vestata for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running make arch-test without explicitly setting ENABLE_ARCH_TEST=1 may fail due to missing prebuilt binaries. This issue arises because the default value of ENABLE_ARCH_TEST is 0, stopping Sail model from being fetched.
Additionally, if ENABLE_SYSTEM=1 was previously set, the build system fetches the kernel image instead of the Sail model. To ensure the correct prebuilt binary is fetched, it is recommended to run make distclean beforehand.
This serves as a temporary solution to #575.