Skip to content

Implement dynamic MCS selection based on signal strength in vWIFI driver #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Implement dynamic MCS selection based on signal strength in vWIFI driver #80

wants to merge 3 commits into from
+57 −5

Conversation

dingsen-Greenhorn
Copy link
Contributor

This commit enhances the vWIFI driver by implementing dynamic Modulation and Coding Scheme (MCS) selection in the vwifi_get_station function, adjusting the MCS index based on signal strength

After implement dynamic MCS can avoid TX power waste for a bad channel quality

@dingsen-Greenhorn
Implement dynamic MCS selection based on signal strength in vWIFI driver
ccbdf38 
This commit enhances the vWIFI driver by implementing
dynamic Modulation and Coding Scheme (MCS) selection in
the `vwifi_get_station` function, adjusting the MCS index
based on signal strength

After implement dynamic MCS can avoid TX power waste for
a bad channel quality
@jserv jserv requested review from jychen0611 and rickywu0421 June 7, 2025 21:44
jserv
jserv requested changes Jun 7, 2025
View reviewed changes
Copy link
Contributor

@jserv jserv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow the consistent coding style.

jychen0611
jychen0611 suggested changes Jun 8, 2025
View reviewed changes
Copy link
Collaborator

@jychen0611 jychen0611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that you are adjusting the MCS based on the current signal strength. However, what if a user wants to set the MCS manually using a command like iw dev wlan0 set bitrates ht-mcs-2.4 <mcs_index>?

To support this, you could consider implementing the set_bitrate_mask() callback in your cfg80211_ops and storing the specified MCS in the corresponding vwifi interface structure.

@dingsen-Greenhorn
Copy link
Contributor Author

It seems that you are adjusting the MCS based on the current signal strength. However, what if a user wants to set the MCS manually using a command like iw dev wlan0 set bitrates ht-mcs-2.4 <mcs_index>?

To support this, you could consider implementing the set_bitrate_mask() callback in your cfg80211_ops and storing the specified MCS in the corresponding vwifi interface structure.

Thanks for you suggestion ,I can try to included the MCS for maunally adjust !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jserv jserv jserv requested changes

@jychen0611 jychen0611 jychen0611 requested changes

@rickywu0421 rickywu0421 Awaiting requested review from rickywu0421

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dingsen-Greenhorn @jserv @jychen0611