Skip over preprocessor files when looking for v4 configs #1159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This technically is based on another PR that's not quite ready yet but I wanted to at least get eyes on these changes. Plan to merge this in next week. |
thecrypticace
force-pushed
the
feat/v4-fallback
branch
from
8e3370d to
72a0dd6
Compare
thecrypticace
force-pushed
the
feat/v4-skip-preprocessor-files
branch
from
a00614f to
4b5a17b
Compare
RobinMalfait
approved these changes
Feb 4, 2025
| function requiresPreprocessor(filepath: string) { | ||
| let ext = path.extname(filepath) | ||
|
|
||
| return ext === '.scss' || ext === '.sass' || ext === '.less' || ext === '.styl' |
There was a problem hiding this comment.
Do we also want to include .pcss or is that not an issue?
There was a problem hiding this comment.
My thinking was that .pcss files (some extension for postcss) the files should still be valid CSS. Buuuut… yeah maybe we should include it anyway. I can relax the check later if need be.
philipp-spiess
approved these changes
Feb 4, 2025
thecrypticace
force-pushed
the
feat/v4-skip-preprocessor-files
branch
from
46b20b8 to
ee8b7ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tailwind CSS v4.0 is more like a preprocessor and should not be used with Sass, Less, or Stylus. We don't want to consider these files to be potential CSS configuration files for a v4 project.