Add some default values for grid row utilities, confusing to have none #1355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamwathan
force-pushed
the
add-grid-row-defaults
branch
from
83185a9 to
3efa8e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some default values to the config for
grid-template-rows,grid-row,grid-row-start, andgrid-row-end. By default I've decided to provide enough values to create a 6 row grid. I considered 12 to match columns but it just seemed like way more than anyone would ever need, while 6 is enough to build a monthly calendar view which seems like a reasonable real-world use-case.Main motivation for adding these is honestly just to make documenting these features less confusing.