Migrate theme(…) to --theme(…), migrate calc(var(--spacing)*x) to --spacing(x)
#15579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobinMalfait
force-pushed
the
feat/migrate-css-functions
branch
from
bebaf72 to
c64290b
Compare
|
TODO:
|
Not on functions that look like variables, e.g.: `--spacing(5)` or `--theme(--color-red-500)`.
RobinMalfait
force-pushed
the
feat/migrate-css-functions
branch
from
ba9bc9b to
0bfae7a
Compare
Only inject `var(…)` for CSS variables, not CSS functions that look like variables. This simplifies it by just checking for a `(`.
philipp-spiess
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the codemod tool to simplify 2 things:
theme(…)call, we try to change it to avar(…), but if that doesn't work for some reason, we will make sure to at least convert it to the more modern--theme(…).theme(spacing.2), we used to convert it tocalc(var(--spacing)*2), but now we will convert it to--spacing(2)instead.