Skip to content

Add first-class support for "responsive" components and bucket children #2025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add first-class support for "responsive" components and bucket children #2025

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 56 additions & 0 deletions __tests__/processPlugins.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1114,6 +1114,62 @@ test("component declarations can optionally ignore 'prefix' option", () => {
`)
})

test('responsive components are generated with the components at-rule argument', () => {
const { components } = processPlugins(
[
function({ addComponents }) {
addComponents(
{
'.btn-blue': {
backgroundColor: 'blue',
},
},
{ variants: ['responsive'] }
)
},
],
makeConfig()
)

expect(css(components)).toMatchCss(`
@responsive components {
@variants {
.btn-blue {
background-color: blue
}
}
}
`)
})

test('components can use the array shorthand to add variants', () => {
const { components } = processPlugins(
[
function({ addComponents }) {
addComponents(
{
'.btn-blue': {
backgroundColor: 'blue',
},
},
['responsive']
)
},
],
makeConfig()
)

expect(css(components)).toMatchCss(`
@responsive components {
@variants {
.btn-blue {
background-color: blue
}
}
}
`)
})

test("component declarations are not affected by the 'important' option", () => {
const { components } = processPlugins(
[
Expand Down
76 changes: 66 additions & 10 deletions __tests__/responsiveAtRule.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ test('it can generate responsive variants', () => {
.chocolate { color: brown; }
}

@tailwind screens;
@screens utilities;
`

const output = `
Expand Down Expand Up @@ -55,7 +55,7 @@ test('it can generate responsive variants with a custom separator', () => {
.chocolate { color: brown; }
}

@tailwind screens;
@screens utilities;
`

const output = `
Expand Down Expand Up @@ -97,7 +97,7 @@ test('it can generate responsive variants when classes have non-standard charact
.chocolate-2\\.5 { color: brown; }
}

@tailwind screens;
@screens utilities;
`

const output = `
Expand Down Expand Up @@ -144,7 +144,7 @@ test('responsive variants are grouped', () => {
.chocolate { color: brown; }
}

@tailwind screens;
@screens utilities;
`

const output = `
Expand Down Expand Up @@ -190,7 +190,7 @@ test('it can generate responsive variants for nested at-rules', () => {
}
}

@tailwind screens;
@screens utilities;
`

const output = `
Expand Down Expand Up @@ -255,7 +255,7 @@ test('it can generate responsive variants for deeply nested at-rules', () => {
}
}

@tailwind screens;
@screens utilities;
`

const output = `
Expand Down Expand Up @@ -320,7 +320,7 @@ test('screen prefix is only applied to the last class in a selector', () => {
.banana li * .sandwich #foo > div { color: yellow; }
}

@tailwind screens;
@screens utilities;
`

const output = `
Expand Down Expand Up @@ -357,7 +357,7 @@ test('responsive variants are generated for all selectors in a rule', () => {
.foo, .bar { color: yellow; }
}

@tailwind screens;
@screens utilities;
`

const output = `
Expand Down Expand Up @@ -394,7 +394,7 @@ test('selectors with no classes cannot be made responsive', () => {
div { color: yellow; }
}

@tailwind screens;
@screens utilities;
`
expect.assertions(1)
return run(input, {
Expand All @@ -417,7 +417,7 @@ test('all selectors in a rule must contain classes', () => {
.foo, div { color: yellow; }
}

@tailwind screens;
@screens utilities;
`
expect.assertions(1)
return run(input, {
Expand All @@ -433,3 +433,59 @@ test('all selectors in a rule must contain classes', () => {
expect(e).toMatchObject({ name: 'CssSyntaxError' })
})
})

test('responsive components are inserted at @screens components', () => {
const input = `
@responsive components {
.banana { color: yellow; }
}

.apple { color: red; }

@screens components;

@responsive {
.chocolate { color: brown; }
}

@screens utilities;
`

const output = `
.banana { color: yellow; }
.apple { color: red; }
@media (min-width: 500px) {
.sm\\:banana { color: yellow; }
}
@media (min-width: 750px) {
.md\\:banana { color: yellow; }
}
@media (min-width: 1000px) {
.lg\\:banana { color: yellow; }
}
.chocolate { color: brown; }
@media (min-width: 500px) {
.sm\\:chocolate { color: brown; }
}
@media (min-width: 750px) {
.md\\:chocolate { color: brown; }
}
@media (min-width: 1000px) {
.lg\\:chocolate { color: brown; }
}
`

return run(input, {
theme: {
screens: {
sm: '500px',
md: '750px',
lg: '1000px',
},
},
separator: ':',
}).then(result => {
expect(result.css).toMatchCss(output)
expect(result.warnings().length).toBe(0)
})
})
Loading