Add overscroll features (Resolves #1957) #2075
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice one! |
|
Looks great, thanks! |
|
Docs PR would definitely be welcome as well, over at tailwindlabs/tailwindcss.com. |
|
@adamwathan Is all that's required in the docs PR adding an |
|
|
Nice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everyone!
This PR adds a set of tailwind classes for the overscroll-behavior css class. It's a relatively new addition (early this year), but it's supported in all major browsers except Safari (77.55% of all users). This closes issue #1957 and uses the classes created by @MarcelloTheArcane.
Example Use
This is my first contribution to Tailwind and I believe I added tests correctly (I modeled them after what's used for the overflow plugin) but please correct me if they're incorrect. I'm also unsure the process for adding new features to the docs, though I'd be happy to contribute there as well.