Skip to content

Use purge.options.safelist as a fallback in JIT mode #4667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

RobinMalfait
Copy link
Member

Currently, for AOT mode you can use the following:

  • purge.safelist
  • purge.options.safelist

But for JIT mode, you can only use:

  • purge.safelist

This commit will ensure that you can use these in both cases:

  • purge.safelist
  • purge.options.safelist

This should make transitioning to JIT a little bit smoother.

Currently, for AOT mode you can use the following:

- purge.safelist
- purge.options.safelist

But for JIT mode, you can only use:

- purge.safelist

This commit will ensure that you can use these in both cases:

- purge.safelist
- purge.options.safelist

This should make transitioning to JIT a little bit smoother.
@RobinMalfait RobinMalfait force-pushed the improve-safelist-migration branch from 7ea759d to 920d2a2 Compare June 16, 2021 16:39
@danstans
Copy link

Hi Robin, will this enable Regex patterns in purge.safelist? Unable to find it or get it working just yet.

@RobinMalfait
Copy link
Member Author

@danstans Hey! No this PR will not enable RegExp patterns sadly. We will likely have a different solution there in the future.

@RobinMalfait RobinMalfait deleted the improve-safelist-migration branch September 1, 2021 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants