Skip to content

Ensure integration tests are up to date #5317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 27, 2021

Conversation

RobinMalfait
Copy link
Member

@RobinMalfait RobinMalfait commented Aug 27, 2021

  • update (old) incorrect snapshots
  • add shadow so that we can test @tailwind base

Wanted to ensure that these are up to date, which will help us when we start refactoring the code in the next cycle so that we guarantee that our integrations don't break.

screenshot of integration tests passing

@RobinMalfait RobinMalfait changed the title ensure integration tests are up to date Ensure integration tests are up to date Aug 27, 2021
The version changed, so it is save to update these.
We were only using `font-bold`, but that doesn't require any base rules.
We try to only inject rules that are required, even for `base` related
rules.
Adding `shadow` will ensure that we can test that `base` rules have been
added.
@RobinMalfait RobinMalfait force-pushed the ensure-integration-tests-are-up-to-date branch from 72a1e53 to e5ab9e6 Compare August 27, 2021 13:48
@RobinMalfait RobinMalfait merged commit 8218aa6 into master Aug 27, 2021
@RobinMalfait RobinMalfait deleted the ensure-integration-tests-are-up-to-date branch August 27, 2021 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant