Fix decoration utility ambiguity
#6217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main reason for the `any` type is so that we don't have to parse the value and can assume that this plugin handles "any" value you give it. This is useful because `decoration-[var(--something)]` would be correctly translated to the correct decoration property. However, we introduce another plugin with the same `decoration` prefix. This means that now both `textDecorationColor` and `textDecorationThickness` have the same base utility name: `decoration`. - `textDecorationColor` had ['color', 'any'] - `textDecorationThickness` had ['length', 'percentage'] This means that `3px` fit both in the `length` data type of the `textDecorationThickness` plugin and in the `any` data type of the `textDecorationColor` plugin. Removing the `any` fixes this. TL;DR: Only have `any` when there are no conflicting utility names.
Having `decoration-[var(--abc)]` is ambiguous because there are multiple plugins that have a `decoration` utility name. In order for this to work you have to prefix it with the type: `decoration-[color:var(--abc)]` which is already tested in this file.
RobinMalfait
force-pushed
the
fix-decoration-ambiguity
branch
from
d9e62fe to
052534e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
decoration-[3px]work automatically.The main reason for the
anytype is so that we don't have to parse thevalue and can assume that this plugin handles "any" value you give it.
This is useful because
decoration-[var(--something)]would becorrectly translated to the correct decoration property. However, we
introduce another plugin with the same
decorationprefix.This means that now both
textDecorationColorandtextDecorationThicknesshave the same base utility name:decoration.textDecorationColorhad ['color', 'any']textDecorationThicknesshad ['length', 'percentage']This means that
3pxfit both in thelengthdata type of thetextDecorationThicknessplugin and in theanydata type of thetextDecorationColorplugin.Removing the
anyfixes this.TL;DR: Only have
anywhen there are no conflicting utility names.