#291 Made id also update attributes. #292
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the
id
property private (_id
) and makes getters and setters so that it updates the attributes as well.In the actual browser changing
id
doesn't affectgetAttribute()
, since the attributes and theid
are separate things. However when doingouterHTML
, the actualid
property is taken into account rather than the originalid
attribute. Not sure if you want the exact same browser behavior, which would be a little tricky, since it would require unparsing and reparsing the rawAttr property to include the updatedid
property. But if this is close enough, if you're good with it.Also fixed a small bug whereby
setAttributes()
didn't update theid
property.