-
Notifications
You must be signed in to change notification settings - Fork 43
Add lua memory option #4736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lua memory option #4736
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice start!
Let's discuss the comments in DM/call.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for an opportunity to help you with it. And I'm sorry that the doc request wasn't so clear at first.
I have a few nits that seem reasonable for me due for consistency with documentation on other options.
Feel free to discuss any of them since my English is not so good and writing the documentation isn't my piece of cake.
@georgiy-belyanin thanks for your review! :) some changes were made. pls approve after the deployment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a couple minor issues left.
@maryiaLichko AFAIU there shouldn't be unresolved conversations at the moment of merging the request. They all should be resolved. Also, usually, the conversations are resolved by the person who left them, at least developers follow this guideline. Could you, please, take into account the minors @p7nov mentioned. I suppose the pull request has been approved by Pavel since the conversations are easy to resolve and the request could be merged right after pushing the fixes and not because they are not important at all. |
Oh, okay, I didn't know it, thank you. |
Resolves #4649.
Configuration reference: new section lua and subsection lua.memory added.
Deployment https://docs.d.tarantool.io/doc/gh-4649-newluamemory/