Skip to content

Add lua memory option #4736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jan 22, 2025
Merged

Add lua memory option #4736

merged 16 commits into from
Jan 22, 2025

Conversation

maryiaLichko
Copy link
Contributor

@maryiaLichko maryiaLichko commented Jan 20, 2025

Resolves #4649.

Configuration reference: new section lua and subsection lua.memory added.

Deployment https://docs.d.tarantool.io/doc/gh-4649-newluamemory/

@maryiaLichko maryiaLichko requested a review from p7nov January 20, 2025 10:44
@maryiaLichko maryiaLichko self-assigned this Jan 20, 2025
@maryiaLichko maryiaLichko linked an issue Jan 20, 2025 that may be closed by this pull request
@maryiaLichko maryiaLichko marked this pull request as draft January 20, 2025 10:47
Copy link
Contributor

@p7nov p7nov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice start!
Let's discuss the comments in DM/call.

@maryiaLichko maryiaLichko marked this pull request as ready for review January 21, 2025 16:38
Copy link
Member

@georgiy-belyanin georgiy-belyanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for an opportunity to help you with it. And I'm sorry that the doc request wasn't so clear at first.
I have a few nits that seem reasonable for me due for consistency with documentation on other options.

Feel free to discuss any of them since my English is not so good and writing the documentation isn't my piece of cake.

@maryiaLichko
Copy link
Contributor Author

@georgiy-belyanin thanks for your review! :) some changes were made. pls approve after the deployment

Copy link
Contributor

@p7nov p7nov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple minor issues left.

@maryiaLichko maryiaLichko merged commit 2d943c9 into latest Jan 22, 2025
1 check passed
@maryiaLichko maryiaLichko deleted the gh-4649-newluamemory branch January 22, 2025 11:06
@georgiy-belyanin
Copy link
Member

@maryiaLichko AFAIU there shouldn't be unresolved conversations at the moment of merging the request. They all should be resolved. Also, usually, the conversations are resolved by the person who left them, at least developers follow this guideline. Could you, please, take into account the minors @p7nov mentioned. I suppose the pull request has been approved by Pavel since the conversations are easy to resolve and the request could be merged right after pushing the fixes and not because they are not important at all.

@maryiaLichko
Copy link
Contributor Author

Also, usually, the conversations are resolved by the person who left them, at least developers follow this guideline.

Oh, okay, I didn't know it, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

config: new lua.memory option.
3 participants