bugfix: unequal timezone after decoding #217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleg-jukovec
force-pushed
the
oleg-jukovec/datetime-non-fixed
branch
from
e99fa4b to
5617d88
Compare
oleg-jukovec
force-pushed
the
oleg-jukovec/datetime-non-fixed
branch
from
5617d88 to
fa0ec5b
Compare
oleg-jukovec
force-pushed
the
oleg-jukovec/datetime-non-fixed
branch
from
fa0ec5b to
dee71a1
Compare
oleg-jukovec
added a commit
that referenced
this pull request
Sep 21, 2022
The patch fixes unequal timezones after Datetime encoding/decoding. It does two things for the fix: 1. After the patch, a location name is picked from Time.Location().String() instead of Time.Zone(). It allows us to encode a timezone from the original name. 2. A decoder function tries to load a location from system location. It allows to handle unfixed timezones properly. Closes #217
oleg-jukovec
force-pushed
the
oleg-jukovec/datetime-non-fixed
branch
from
dee71a1 to
e5c2604
Compare
oleg-jukovec
added a commit
that referenced
this pull request
Sep 21, 2022
The patch fixes unequal timezones after Datetime encoding/decoding. It does two things for the fix: 1. After the patch, a location name is picked from Time.Location().String() instead of Time.Zone(). It allows us to encode a timezone from the original name. 2. A decoder function tries to load a location from system location. It allows to handle unfixed timezones properly. Closes #217
oleg-jukovec
force-pushed
the
oleg-jukovec/datetime-non-fixed
branch
from
e5c2604 to
4c392a2
Compare
oleg-jukovec
changed the title
oleg-jukovec
added a commit
that referenced
this pull request
Sep 21, 2022
The patch fixes unequal timezones after Datetime encoding/decoding. It does two things for the fix: 1. After the patch, a location name is picked from Time.Location().String() instead of Time.Zone(). It allows us to encode a timezone from the original name. 2. A decoder function tries to load a location from system location. It allows to handle unfixed timezones properly. Closes #217
oleg-jukovec
force-pushed
the
oleg-jukovec/datetime-non-fixed
branch
from
4c392a2 to
fbf09db
Compare
|
After additional experiments and research, I decided to go the opposite way: pick up an original name of a timezone from The main drawbacks of this approach are that "Local" location is not supported. But it looks logical from a one point of view. In any case, it looks simpler than the previous logic. |
oleg-jukovec
added a commit
that referenced
this pull request
Sep 22, 2022
The patch fixes unequal timezones after Datetime encoding/decoding. It does two things for the fix: 1. After the patch, a location name is picked from Time.Location().String() instead of Time.Zone(). It allows us to encode a timezone from the original name. 2. A decoder function tries to load a location from system location. It allows to handle unfixed timezones properly. Closes #217
oleg-jukovec
force-pushed
the
oleg-jukovec/datetime-non-fixed
branch
from
fbf09db to
b583c23
Compare
So you didn't found a way to parse |
oleg-jukovec
added a commit
that referenced
this pull request
Sep 22, 2022
The patch fixes unequal timezones after Datetime encoding/decoding. It does two things for the fix: 1. After the patch, a location name is picked from Time.Location().String() instead of Time.Zone(). It allows us to encode a timezone from the original name. 2. A decoder function tries to load a location from system location. It allows to handle unfixed timezones properly. Closes #217
oleg-jukovec
force-pushed
the
oleg-jukovec/datetime-non-fixed
branch
from
b583c23 to
ac5c725
Compare
oleg-jukovec
added a commit
that referenced
this pull request
Sep 22, 2022
The patch fixes unequal timezones after Datetime encoding/decoding. It does two things for the fix: 1. After the patch, a location name is picked from Time.Location().String() instead of Time.Zone(). It allows us to encode a timezone from the original name. 2. A decoder function tries to load a location from system location. It allows to handle unfixed timezones properly. Closes #217
oleg-jukovec
force-pushed
the
oleg-jukovec/datetime-non-fixed
branch
from
ac5c725 to
86390b6
Compare
oleg-jukovec
added a commit
that referenced
this pull request
Sep 22, 2022
The patch fixes unequal timezones after Datetime encoding/decoding. It does two things for the fix: 1. After the patch, a location name is picked from Time.Location().String() instead of Time.Zone(). It allows us to encode a timezone from the original name. 2. A decoder function tries to load a location from system location. It allows to handle unfixed timezones properly. Closes #217
oleg-jukovec
force-pushed
the
oleg-jukovec/datetime-non-fixed
branch
from
86390b6 to
59cf935
Compare
oleg-jukovec
added a commit
that referenced
this pull request
Sep 22, 2022
The patch fixes unequal timezones after Datetime encoding/decoding. It does two things for the fix: 1. After the patch, a location name is picked from Time.Location().String() instead of Time.Zone(). It allows us to encode a timezone from the original name. 2. A decoder function tries to load a location from system location. It allows to handle unfixed timezones properly. Closes #217
oleg-jukovec
force-pushed
the
oleg-jukovec/datetime-non-fixed
branch
from
59cf935 to
7099bee
Compare
DifferentialOrange
approved these changes
Sep 22, 2022
There was a problem hiding this comment.
As far as I remember, the only question left unanswered is Local parsing. If you (or @LeonidVas) find the solution, I'll get back and review the updates. If you decide to leave it as is, let it be (I think we'll wait for @LeonidVas on this question too).
oleg-jukovec
requested review from
vr009 and
LeonidVas
and removed request for
vr009
The patch fixes unequal timezones after Datetime encoding/decoding. It does two things for the fix: 1. After the patch, a location name is picked from Time.Location().String() instead of Time.Zone(). It allows us to encode a timezone from the original name. 2. A decoder function tries to load a location from system location. It allows to handle unfixed timezones properly. Closes #217
oleg-jukovec
force-pushed
the
oleg-jukovec/datetime-non-fixed
branch
from
7099bee to
29cd8d5
Compare
vr009
approved these changes
Oct 4, 2022
oleg-jukovec
added a commit
that referenced
this pull request
Oct 4, 2022
Overview
The release adds support for the latest version of the
queue package with master-replica switching.
Breaking changes
There are no breaking changes in the release.
New features
Support the queue 1.2.1 (#177).
ConnectionHandler interface for handling changes of connections in
ConnectionPool (#178)
Execute, ExecuteTyped and ExecuteAsync methods to
ConnectionPool (#176)
ConnectorAdapter type to use ConnectionPool as Connector
interface (#176)
An example how to use queue and connection_pool subpackages
together (#176)
Bugfixes
Mode type description in the connection_pool subpackage (#208)
Missed Role type constants in the connection_pool subpackage (#208)
ConnectionPool does not close UnknownRole connections (#208)
Segmentation faults in ConnectionPool requests after
disconnect (#208)
Addresses in ConnectionPool may be changed from an external
code (#208)
ConnectionPool recreates connections too often (#208)
A connection is still opened after ConnectionPool.Close() (#208)
Future.GetTyped() after Future.Get() does not decode response
correctly (#213)
Decimal package use a test function GetNumberLength instead of a
package-level function getNumberLength (#219)
Datetime location after encode + decode is unequal (#217)
oleg-jukovec
added a commit
that referenced
this pull request
Oct 4, 2022
Overview
The release adds support for the latest version of the
queue package with master-replica switching.
Breaking changes
There are no breaking changes in the release.
New features
Support the queue 1.2.1 (#177).
ConnectionHandler interface for handling changes of connections in
ConnectionPool (#178).
Execute, ExecuteTyped and ExecuteAsync methods to
ConnectionPool (#176).
ConnectorAdapter type to use ConnectionPool as Connector
interface (#176).
An example how to use queue and connection_pool subpackages
together (#176).
Bugfixes
Mode type description in the connection_pool subpackage (#208).
Missed Role type constants in the connection_pool
subpackage (#208).
ConnectionPool does not close UnknownRole connections (#208).
Segmentation faults in ConnectionPool requests after
disconnect (#208).
Addresses in ConnectionPool may be changed from an external
code (#208).
ConnectionPool recreates connections too often (#208).
A connection is still opened after ConnectionPool.Close() (#208).
Future.GetTyped() after Future.Get() does not decode response
correctly (#213).
Decimal package use a test function GetNumberLength instead of a
package-level function getNumberLength (#219).
Datetime location after encode + decode is unequal (#217).
Merged
oleg-jukovec
added a commit
that referenced
this pull request
Oct 5, 2022
Overview
The release adds support for the latest version of the
queue package with master-replica switching.
Breaking changes
There are no breaking changes in the release.
New features
Support the queue 1.2.1 (#177).
ConnectionHandler interface for handling changes of connections in
ConnectionPool (#178).
Execute, ExecuteTyped and ExecuteAsync methods to
ConnectionPool (#176).
ConnectorAdapter type to use ConnectionPool as Connector
interface (#176).
An example how to use queue and connection_pool subpackages
together (#176).
Bugfixes
Mode type description in the connection_pool subpackage (#208).
Missed Role type constants in the connection_pool
subpackage (#208).
ConnectionPool does not close UnknownRole connections (#208).
Segmentation faults in ConnectionPool requests after
disconnect (#208).
Addresses in ConnectionPool may be changed from an external
code (#208).
ConnectionPool recreates connections too often (#208).
A connection is still opened after ConnectionPool.Close() (#208).
Future.GetTyped() after Future.Get() does not decode response
correctly (#213).
Decimal package use a test function GetNumberLength instead of a
package-level function getNumberLength (#219).
Datetime location after encode + decode is unequal (#217).
oleg-jukovec
added a commit
that referenced
this pull request
Oct 31, 2022
Overview
The release adds support for the latest version of the
queue package with master-replica switching.
Breaking changes
There are no breaking changes in the release.
New features
Support the queue 1.2.1 (#177).
ConnectionHandler interface for handling changes of connections in
ConnectionPool (#178).
Execute, ExecuteTyped and ExecuteAsync methods to
ConnectionPool (#176).
ConnectorAdapter type to use ConnectionPool as Connector
interface (#176).
An example how to use queue and connection_pool subpackages
together (#176).
Bugfixes
Mode type description in the connection_pool subpackage (#208).
Missed Role type constants in the connection_pool
subpackage (#208).
ConnectionPool does not close UnknownRole connections (#208).
Segmentation faults in ConnectionPool requests after
disconnect (#208).
Addresses in ConnectionPool may be changed from an external
code (#208).
ConnectionPool recreates connections too often (#208).
A connection is still opened after ConnectionPool.Close() (#208).
Future.GetTyped() after Future.Get() does not decode response
correctly (#213).
Decimal package use a test function GetNumberLength instead of a
package-level function getNumberLength (#219).
Datetime location after encode + decode is unequal (#217).
Wrong interval arithmetic with timezones (#221).
Invalid MsgPack if STREAM_ID > 127 (#224).
queue.Take() returns an invalid task (#222).
oleg-jukovec
added a commit
that referenced
this pull request
Oct 31, 2022
Overview
The release adds support for the latest version of the
queue package with master-replica switching.
Breaking changes
There are no breaking changes in the release.
New features
Support the queue 1.2.1 (#177).
ConnectionHandler interface for handling changes of connections in
ConnectionPool (#178).
Execute, ExecuteTyped and ExecuteAsync methods to
ConnectionPool (#176).
ConnectorAdapter type to use ConnectionPool as Connector
interface (#176).
An example how to use queue and connection_pool subpackages
together (#176).
Bugfixes
Mode type description in the connection_pool subpackage (#208).
Missed Role type constants in the connection_pool
subpackage (#208).
ConnectionPool does not close UnknownRole connections (#208).
Segmentation faults in ConnectionPool requests after
disconnect (#208).
Addresses in ConnectionPool may be changed from an external
code (#208).
ConnectionPool recreates connections too often (#208).
A connection is still opened after ConnectionPool.Close() (#208).
Future.GetTyped() after Future.Get() does not decode response
correctly (#213).
Decimal package use a test function GetNumberLength instead of a
package-level function getNumberLength (#219).
Datetime location after encode + decode is unequal (#217).
Wrong interval arithmetic with timezones (#221).
Invalid MsgPack if STREAM_ID > 127 (#224).
queue.Take() returns an invalid task (#222).
oleg-jukovec
added a commit
that referenced
this pull request
Nov 2, 2022
Overview
The release adds support for the latest version of the
queue package with master-replica switching.
Breaking changes
There are no breaking changes in the release.
New features
Support the queue 1.2.1 (#177).
ConnectionHandler interface for handling changes of connections in
ConnectionPool (#178).
Execute, ExecuteTyped and ExecuteAsync methods to
ConnectionPool (#176).
ConnectorAdapter type to use ConnectionPool as Connector
interface (#176).
An example how to use queue and connection_pool subpackages
together (#176).
Bugfixes
Mode type description in the connection_pool subpackage (#208).
Missed Role type constants in the connection_pool
subpackage (#208).
ConnectionPool does not close UnknownRole connections (#208).
Segmentation faults in ConnectionPool requests after
disconnect (#208).
Addresses in ConnectionPool may be changed from an external
code (#208).
ConnectionPool recreates connections too often (#208).
A connection is still opened after ConnectionPool.Close() (#208).
Future.GetTyped() after Future.Get() does not decode response
correctly (#213).
Decimal package use a test function GetNumberLength instead of a
package-level function getNumberLength (#219).
Datetime location after encode + decode is unequal (#217).
Wrong interval arithmetic with timezones (#221).
Invalid MsgPack if STREAM_ID > 127 (#224).
queue.Take() returns an invalid task (#222).
oleg-jukovec
added a commit
that referenced
this pull request
Nov 2, 2022
Overview
The release adds support for the latest version of the
queue package with master-replica switching.
Breaking changes
There are no breaking changes in the release.
New features
Support the queue 1.2.1 (#177).
ConnectionHandler interface for handling changes of connections in
ConnectionPool (#178).
Execute, ExecuteTyped and ExecuteAsync methods to
ConnectionPool (#176).
ConnectorAdapter type to use ConnectionPool as Connector
interface (#176).
An example how to use queue and connection_pool subpackages
together (#176).
Bugfixes
Mode type description in the connection_pool subpackage (#208).
Missed Role type constants in the connection_pool
subpackage (#208).
ConnectionPool does not close UnknownRole connections (#208).
Segmentation faults in ConnectionPool requests after
disconnect (#208).
Addresses in ConnectionPool may be changed from an external
code (#208).
ConnectionPool recreates connections too often (#208).
A connection is still opened after ConnectionPool.Close() (#208).
Future.GetTyped() after Future.Get() does not decode response
correctly (#213).
Decimal package use a test function GetNumberLength instead of a
package-level function getNumberLength (#219).
Datetime location after encode + decode is unequal (#217).
Wrong interval arithmetic with timezones (#221).
Invalid MsgPack if STREAM_ID > 127 (#224).
queue.Take() returns an invalid task (#222).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patch fixes unequal timezones after Datetime encoding/decoding. It does two things for the fix:
I didn't forget about (remove if it is not applicable):