memcached: allow to pass port as a number to memcached.create() #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For creating memcached instance module requires instance name, URI and table with options. URI is a string with hostname and port number separated by colon. Instead URI user can pass a port as a number, but memcached doesn't expect it and fails with exception. Patch fixes it by adding conversion of uri to a string. Fixes #107
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For creating memcached instance module requires instance name, URI and
table with options. URI is a string with hostname and port number
separated by colon. Instead URI user can pass a port as a number, but
memcached doesn't expect it and fails with exception. Patch fixes it by
adding conversion of uri to a string.
Fixes #107