Skip to content

Add forgotten connection context disposal for SASL #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 8, 2018
Merged

Add forgotten connection context disposal for SASL #45

merged 1 commit into from
Oct 8, 2018

Conversation

bigbes
Copy link
Contributor

@bigbes bigbes commented Oct 6, 2018

@bigbes bigbes requested a review from Totktonada October 6, 2018 08:02
Totktonada
Totktonada approved these changes Oct 8, 2018
View reviewed changes
Copy link
Member

@Totktonada Totktonada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@bigbes
Copy link
Contributor Author

bigbes commented Oct 8, 2018 •
edited
Loading

@Totktonada tarantool/tarantool#3392 (comment) reports that sasl is now disposed, no garbage is generated. Let's get it merged

@Totktonada Totktonada merged commit b5d0ff5 into tarantool:master Oct 8, 2018
@Totktonada Totktonada mentioned this pull request Oct 8, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Totktonada Totktonada Totktonada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tarantool high memory usage
2 participants
@bigbes @Totktonada