Skip to content
This repository was archived by the owner on May 15, 2021. It is now read-only.

Builds have stopped being cancelled #67

Closed
bendavies opened this issue Feb 4, 2021 · 1 comment · Fixed by #65
Closed

Builds have stopped being cancelled #67

bendavies opened this issue Feb 4, 2021 · 1 comment · Fixed by #65
Assignees

Comments

@bendavies
Copy link

bendavies commented Feb 4, 2021

Describe the bug: バグの概要

Hi there,

I'm seeing builds not being cancelled on release 1.7.0
I'm not sure when this stopped working.

To Reproduce: 再現手順

Push 2 commits to a branch.
the 1st commits workflow is not cancelled.

Expected behavior: 期待する動作

the 1st commits workflow is cancelled.

Screenshots: スクリーンショット

You can see here that run_number 794 is not cancelled.

==================================================
Version:  technote-space/[email protected]
          b7d9400b28a6eed16e965e2026a95cf221610794
Event:    pull_request
Action:   synchronize
sha:      1535d528b273c583f0990c58cc6fe7beda7d2279
ref:      refs/pull/699/merge
Labels:
owner:    owsy
repo:     abacus-webapp

Dump context
Dump Payload
==================================================

> run id: 537906920
run:
  {
    id: 537906920,
    head_branch: 'fix-docker-build',
    head_sha: 'cfe91806d0a0094349731074aa25826456f6f8aa',
    run_number: 795,
    event: 'pull_request',
    status: 'queued',
    created_at: '2021-02-04T17:31:21Z',
    updated_at: '2021-02-04T17:31:52Z'
  }
> workflow id: 739966
target event: pull_request
target branch: fix-docker-build
workflow runs:
  [
    {
      id: 537906355,
      head_branch: 'fix-docker-build',
      head_sha: '872d25243874d478a07a39bc4aa28aff42e569ca',
      run_number: 794,
      event: 'pull_request',
      status: 'in_progress',
      created_at: '2021-02-04T17:31:03Z',
      updated_at: '2021-02-04T17:31:47Z'
    }
  ]

Cancelling...
  > total: 0

Thanks!

@technote-space technote-space added the Status: More Information Needed Follow-up required in order to be actionable label Feb 5, 2021
@github-actions github-actions bot added the Status: In Progress Tracking issues with work in progress label Feb 5, 2021
technote-space added a commit that referenced this issue Feb 5, 2021
chore: consider that api not include current run (#67)
@github-actions github-actions bot mentioned this issue Feb 5, 2021
@github-actions github-actions bot removed the Status: In Progress Tracking issues with work in progress label Feb 5, 2021
@bendavies
Copy link
Author

hi @technote-space thanks for the fix - confirmed it seems to work!

@no-response no-response bot removed the Status: More Information Needed Follow-up required in order to be actionable label Feb 5, 2021
@no-response no-response bot reopened this Feb 5, 2021
@github-actions github-actions bot added the Status: In Progress Tracking issues with work in progress label Feb 5, 2021
@github-actions github-actions bot removed the Status: In Progress Tracking issues with work in progress label Feb 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants