This repository was archived by the owner on Jul 1, 2023. It is now read-only.
Minor fix for AD. #106
Merged
Minor fix for AD. #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rxwei
approved these changes
Apr 21, 2019
|
Thanks! |
|
It's not a bug though. We just need a API that allows you to use any function/property while forcing the derivative to be zero. |
Sorry, the "bug fix" commit was referring to the use of |
|
Got it! |
|
Since this doesn't compile with SwiftPM, I'll have to revert it along with #70 to iterate further. Happy to help with resolving the compilation issues! |
rxwei
added a commit
that referenced
this pull request
Apr 21, 2019
Shashi456
pushed a commit
to Shashi456/swift-apis
that referenced
this pull request
Apr 29, 2019
Shashi456
pushed a commit
to Shashi456/swift-apis
that referenced
this pull request
Apr 29, 2019
This reverts commit c499e16.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rxwei This is based on what you mentioned in this email thread.