Skip to content
This repository was archived by the owner on Jul 1, 2023. It is now read-only.

Relax Tensor initializer generic requirements. #1061

Merged
merged 1 commit into from
Aug 18, 2020

Conversation

dan-zheng
Copy link
Member

@dan-zheng dan-zheng commented Aug 14, 2020

Tensor initializers taking scalars now require that scalars are Collection instead of RandomAccessCollection.
Collection.count is the only protocol requirement used in the initializers' bodies.

`Tensor` initializers taking scalars require that scalars are `Collection`
instead of `RandomAccessCollection`.
@dan-zheng dan-zheng requested a review from dabrahams August 14, 2020 16:42
Copy link
Contributor

@dabrahams dabrahams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dabrahams dabrahams merged commit a1b6606 into master Aug 18, 2020
@dabrahams dabrahams deleted the relax-tensor-init-requirements branch August 18, 2020 20:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants